Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): use sumologic.metrics.excludeNamespaceRegex instead of sumologic.logs.container.excludeNamespaceRegex #3428

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

andrzej-stencel
Copy link
Contributor

@andrzej-stencel andrzej-stencel commented Dec 6, 2023

The property sumologic.logs.container.excludeNamespaceRegex was being used to filter out not only container logs, but also metrics. This was incorrect.

I have introduced a new property sumologic.metrics.excludeNamespaceRegex that can now be used to filter out metrics based on namespaces.

@andrzej-stencel andrzej-stencel requested a review from a team as a code owner December 6, 2023 15:03
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, missing changelog

…f `sumologic.logs.container.excludeNamespaceRegex`
@andrzej-stencel andrzej-stencel merged commit de51b52 into main Dec 8, 2023
68 checks passed
@andrzej-stencel andrzej-stencel deleted the metrics-exclude-namespace-regex branch December 8, 2023 09:23
andrzej-stencel added a commit that referenced this pull request Dec 8, 2023
…f `sumologic.logs.container.excludeNamespaceRegex`

Backports #3428
andrzej-stencel added a commit that referenced this pull request Dec 8, 2023
…f `sumologic.logs.container.excludeNamespaceRegex`

Backports #3428
andrzej-stencel added a commit that referenced this pull request Dec 8, 2023
…f `sumologic.logs.container.excludeNamespaceRegex` (#3436)

Backports #3428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants